-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check if typedefs are being unnecessarily resolved #124
base: main
Are you sure you want to change the base?
Conversation
0fc3cc8
to
f01e984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
}; | ||
)"); | ||
|
||
clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); | |
auto *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); |
|
||
clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); | ||
auto *CtorTDT = | ||
(clang::CXXConstructorDecl*) Cpp::GetDefaultConstructor(ClassTDT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]
(clang::CXXConstructorDecl*) Cpp::GetDefaultConstructor(ClassTDT);
^
void* objectTDT = nullptr; | ||
FCI_CtorTDT.Invoke((void*)&objectTDT); | ||
EXPECT_TRUE(objectTDT != nullptr); | ||
clang::NamedDecl *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
clang::NamedDecl *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); | |
auto *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); |
This PR is stale because it has been open for 90 days with no activity. |
Same as #97